Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the implementation of kinesisanalyticsv2 service client #13161

Merged
merged 1 commit into from
May 6, 2020
Merged

Complete the implementation of kinesisanalyticsv2 service client #13161

merged 1 commit into from
May 6, 2020

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11652.
Relates #7332.
Relates #7468.
Relates #11347.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

n/a

@ewbankkit ewbankkit requested a review from a team May 5, 2020 12:28
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. labels May 5, 2020
@ewbankkit ewbankkit changed the title Complete implementation of kinesisanalyticsv2 service client Complete the implementation of kinesisanalyticsv2 service client May 5, 2020
@ewbankkit ewbankkit mentioned this pull request May 5, 2020
Merged
bflad
bflad approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad added service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 6, 2020
@bflad bflad added this to the v2.61.0 milestone May 6, 2020
@bflad bflad merged commit 66d802f into hashicorp:master May 6, 2020
@ewbankkit ewbankkit deleted the add-kinesisanalyticsv2-service-client branch May 6, 2020 12:04
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.61.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@ewbankkit @adamdecaf
Complete implementation of kinesisanalyticsv2 service client. (hashic…
fc1decb 
…orp#13161)
@ghost
Copy link

ghost commented Jun 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.61.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @bflad